Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builders.m.o location #15614

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

janbrasna
Copy link
Contributor

@janbrasna janbrasna commented Dec 2, 2024

One-line summary

Updates future.mozilla.org/builders link and relevant redirects to builders.mozilla.org

Significant changes and points to review

https://builders.mozilla.org is up now so this is good to go.

Issue / Bugzilla link

#15613

Testing

http://localhost:8000/builders/

@stephaniehobson
Copy link
Contributor

@janbrasna needs a rebase, sorry!

@stephaniehobson stephaniehobson added the Needs Review Awaiting code review label Dec 2, 2024
@janbrasna janbrasna changed the title Update /builders location Update builders.m.o location & copy Dec 2, 2024
@janbrasna

This comment was marked as resolved.

@stevejalim
Copy link
Collaborator

@janbrasna The URL change will be handled initially by a redirect within future.m.o which will be pushed live at launch time. So feel free to remove the URL change from this PR if it makes things simpler

@janbrasna janbrasna changed the title Update builders.m.o location & copy Update builders.m.o location Dec 3, 2024
@janbrasna
Copy link
Contributor Author

I understood the request the other way around; that until live the subdomain would redirect back to current future.m.o location.

I've separated out the ftl change to #15624 so this can sit around until needed.

@stevejalim
Copy link
Collaborator

The builders.m.o redirect in future.m.o is now live, FWIW

@stephaniehobson stephaniehobson self-assigned this Dec 3, 2024
Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ 🏗️

@stephaniehobson
Copy link
Contributor

@janbrasna Something went horribly wrong when I tried to fix a merge conflict 😫 Could you please rebase and force push?

@janbrasna
Copy link
Contributor Author

@stephaniehobson NP, I had that ref already prepared & resolved, you were just quicker;) The merge did seem alright, but here's a clean rebase nonetheless, passing. ✅

@stephaniehobson stephaniehobson merged commit 542ae7f into mozilla:main Dec 3, 2024
5 checks passed
@janbrasna janbrasna deleted the upd/builders-url branch December 3, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants