Remove inline styles from job listings #15637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhudson
reviewed
Dec 3, 2024
| @@ -78,7 +73,6 @@ def __iter__(self): | |||
| cleaner = bleach.sanitizer.Cleaner( | |||
| tags=ALLOWED_TAGS, | |||
| attributes=ALLOWED_ATTRS, | |||
| css_sanitizer=CSSSanitizer(allowed_css_properties=ALLOWED_STYLES), | |||
There was a problem hiding this comment.
This is good. Did we want to consider removing class attributes as well? Since, the ones I saw reference classes that don't exist on bedrock.
There was a problem hiding this comment.
Yea they have the "gmail_default" there on the container… but it's at least to grab the content in DOM if needed, so I didn't bother to xcheck all the content it's not actually breaking anything… (will grep/sed again and check what classes are there at all)
There was a problem hiding this comment.
So the most common classes are: external-link, content-pay, pay-input, description, title, pay-range, divider, etc. … so I'd probably keep them in, in case they'd need to be targeted at some point?
robhudson
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
This bleaches inline styles in Greenhouse API sync, to avoid unsafe-inline style CSP violations (and unblock moving that to enforced policies…)
Significant changes and points to review
Currently almost all the styles from the original listing data (align, color etc.) are removed already, leaving only either empty
style=""behind, or afont-weight: 400that is the default anyways. So it can be removed completely.(It will have to go through data sync cron first to update in prod.)
Issue / Bugzilla link
Resolves #15633 (& refs #14840)
Testing
python manage.py sync_greenhouse(in my case, in containerized env, it was actually
make clean build runfollowed bymake shellin another session with the management command run from there…)http://localhost:8000/en-US/careers/position/gh/6135741/
http://localhost:8000/en-US/careers/position/gh/6393976/