Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

same space before and after legal section in footer (fix #15659) #15663

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

wen-2018
Copy link
Collaborator

@wen-2018 wen-2018 commented Dec 4, 2024

One-line summary

This PR updates the footer legal section styles to allow same space before and after legal section.

Significant changes and points to review

  • Footer legal section spaces

Issue / Bugzilla link

#15659

Testing

http://localhost:8000/en-US/

  • Test for various screen sizes

@wen-2018 wen-2018 requested a review from a team as a code owner December 4, 2024 14:56
@wen-2018 wen-2018 added Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less Frontend HTML, CSS, JS... client side stuff Refresh 🦖 Work related to the 2024 site refresh labels Dec 4, 2024
Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a rebase after #15654 merged to resolve some merge conflicts. Then r+wc 🪇

@craigcook craigcook removed the Needs Review Awaiting code review label Dec 4, 2024
@craigcook craigcook self-assigned this Dec 4, 2024
@wen-2018 wen-2018 force-pushed the footer-legal-style-tweaks branch from 884d981 to 51a5897 Compare December 5, 2024 15:13
@wen-2018 wen-2018 force-pushed the footer-legal-style-tweaks branch from 51a5897 to aa6e304 Compare December 5, 2024 15:15
@wen-2018 wen-2018 merged commit a16e1c5 into mozilla:main Dec 5, 2024
5 checks passed
@wen-2018 wen-2018 deleted the footer-legal-style-tweaks branch December 5, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff Refresh 🦖 Work related to the 2024 site refresh Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants