Update CSP to move upgrade-insecure-requests to enforced policy
#15782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejalim
approved these changes
Dec 19, 2024
|
Investigating if this can interfere with localhost development which is run over http://… (EDIT: ah so there's implementation differences as the spec is somewhat wild — I'll follow up in the tracking issue: …) |
janbrasna
reviewed
Dec 22, 2024
| @@ -110,6 +110,7 @@ | |||
| "connect-src": list(set(_csp_default_src + _csp_connect_src)), | |||
| # support older browsers (mainly Safari) | |||
| "frame-src": _csp_child_src, | |||
| "upgrade-insecure-requests": True, | |||
There was a problem hiding this comment.
Wondering if there is a good condition to skip this in local dev (which if DEV is not, as that is used in demo/dev deployments too…), or if this has to be kept unconditionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
This PR adds the upgrade-insecure-requests directive to our Content Security Policy (CSP). This directive automatically upgrades HTTP requests to HTTPS, improving security by ensuring all content is loaded over a secure connection.
This has been in our report-only policy with no issue detected.
Issue / Bugzilla link
#11943
Testing