Storybook UI Refinement WIP #4902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `Breach` type in functions/universal/breaches,
which was created when first introducing TypeScript and the flow
of data was still unclear, but by now had overlap with other types
and no clear provenance.
Instead, there are now three breach-related types, that represent
where the data came from:
- HibpGetBreachesResponse: this is an array of breach elements as
returned from the HIBP API, unprocessed.
Properties are in PascalCase, so are a
breach's data classes.
- BreachRow: this is a breach's data as stored in our database,
along with some data we added to it, such as a favicon
URL. Properties are snake_case, and data classes are
lowercased and kebab-cased by the
formatDataClassesArray function.
- HibpLikeDbBreach: this is a breach's data fetched from the
database, but stored in an object meant to look
like the ones in HibpGetBreachesResponse. In
other words, it contains the same data as
BreachRow (including lowercased, kebab-cased
data classes), but on PascalCase properties.
The latter is somewhat of a historical artefact, because we used
to try to load breaches from our database, then if our database
didn't contain any breaches yet, fetch them live from the HIBP API
and continue working with that.
We no longer do that: now, even after fetching them from the HIBP
API, we do a new query to get them from the database and process
them into HibpLikeDbBreach, so that we can assume a consisent data
structure everywhere we work with breaches.
codemist
force-pushed
the
MNTOR-3395
branch
from
282263e to
6751f89
Compare
|
@codemist Since this was last touched more than a month ago, and since I see no tickets in progress related to this, I'll close this for now, but feel free to re-open if I shouldn't have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-
Figma:
Description
Screenshot (if applicable)
Not applicable.
How to test
Checklist (Definition of Done)