MNTOR-4060 Remove duplicate sign-in button on mobile, and prevent logo from shrinking #5646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ad6d3be.
The redesigned landing page no longer has a "Sign In" button in the top bar, so it added one to the top nav bar (the bar below the top bar). However, since the <TopNavBar> component is also used by the current landing page, as well as by the <Shell> we use when the user is logged in (although the Sign In button is not rendered there), that could lead to duplicate buttons. Thus, I split it up into two components, one for the old, and one for the new landing page.
This aligns the horizontal padding with that of the sections on the landing page, which allows the logo to stay at full size for longer.
|
Preview URL 🚀 : https://blurts-server-pr-5646-mgjlpikfea-uk.a.run.app |
Vinnl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-4060
Figma:
Description
For the redesigned landing page, we added a sign-in button to the
<TopNavBar>component. This was used in three places:<PublicShell>),<LandingView>), and<MobileShell>).I split the
<TopNavBar>into a redesigned version and the old version, reverting the recent changes in the latter - thus, only the former has the sign-in button. I then updated 1. to use the redesigned version, and 3. to use the version depending on the experiment and flag status.I also updated the padding in the old top nav to remove some superfluous and inconsistent spacing.
Screenshot (if applicable)
New:
Old:
How to test
Visit the landing page, both the old one and the new one, and inside and outside the US. Verify that only one sign-in button is visible.
Checklist (Definition of Done)