MNTOR-3893 - Fix qa custom broker tool #5647
Conversation
|
Preview URL 🚀 : https://blurts-server-pr-5647-mgjlpikfea-uk.a.run.app |
codemist
force-pushed
the
mntor-3893-2
branch
from
3c23412 to
9015002
Compare
| @@ -106,11 +107,21 @@ export default async function DashboardPage(props: Props) { | |||
| return redirect("/user/welcome"); | |||
| } | |||
|
|
|||
| const latestScan = await getScanResultsWithBroker( | |||
| const enabledFeatureFlags = await getEnabledFeatureFlags({ | |||
There was a problem hiding this comment.
we should wrap the logic here with an if check (safer):
if (not prod && feature flag enabled for this email) {
scanResults = getMock()
} else {
scanResults = getReal()
}
This way we 1) only go to the db once 2) logic seems clearer to read
| @@ -491,6 +489,45 @@ async function getScanResultsWithBroker( | |||
| return { scan: scan ?? null, results: scanResults } as LatestOnerepScanData; | |||
| } | |||
|
|
|||
| async function getMockedScanResults( | |||
There was a problem hiding this comment.
Is the naming better with getMockedScanResults with getMockedScanResultsWithBrokers? This returns the aggregated results I believe
src/db/tables/qa_customs.ts
Outdated
| const res = (await knex("qa_custom_brokers") | ||
| .where("onerep_profile_id", onerep_profile_id) | ||
| .select("*")) as QaBrokerData[]; | ||
| async function getAllQaCustomBrokers(): Promise< |
There was a problem hiding this comment.
I think we should rename this to something like scanResultWithBrokers.. also for the UI, it might be confusing to see the word "brokers" and see scan results attributes
codemist
force-pushed
the
mntor-3893-2
branch
from
c7cb116 to
000bb67
Compare
| @@ -47,24 +47,13 @@ function duplicateObj(obj: mockInputs, n: string | undefined) { | |||
| return Array.from({ length: howMany }, () => obj); | |||
| } | |||
|
|
|||
| export async function GET(req: NextRequest) { | |||
| export async function GET() { | |||
There was a problem hiding this comment.
I removed the need for profileId here since it's not being used.
| const scanResults = useMockedScans | ||
| ? await getMockedScanResults(profileId) | ||
| : await getScanResultsWithBroker(profileId, hasPremium(session.user)); |
There was a problem hiding this comment.
It should only load one db at a time.
codemist
force-pushed
the
mntor-3893-2
branch
from
a402479 to
6de72c3
Compare
References:
Jira: MNTOR-3893
Figma:
Description
Screenshot (if applicable)
Not applicable.
How to test
Checklist (Definition of Done)