MNTOR-4066: Turn cronjob into long-running interruptible task #5658
+25
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-4066
Figma:
Description
This makes the breach-alerts cronjob explicitly interruptible via SIGINT, and adds a script to turn it into a long-running task, instead of a script meant for periodical execution. This should enable scaling it based on the size of the PubSub queue.
We should be able to merge this without any changes to our infra, and after merging allow us to make changes to our infra without breaking the script. (In other words, it allows for a backwards-compatible transition.)
How to test
Follow the instructions under PubSub in the readme, but replace
dev:cron:breach-alerts
bydev:task:breach-alerts
. (Or alternatively, setLOOP="true"
in your environment. We can remove that env var after we've transitioned.)You can test out that it exits on
SIGINT
by finding the process ID, then runningkill -SIGINT <process ID>
.Checklist (Definition of Done)