This repository has been archived by the owner on Jan 7, 2025. It is now read-only.
Added a new global rule for CookieScript #356
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greg-21
force-pushed
the
cookiescript-global-rule
branch
from
ac36281 to
e7dbb10
Compare
This was referenced Mar 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I propose adding support for the CookieScript CMP, which is used in the wild by various websites on the Internet, and removing the one site-specific rule that will no longer be necessary thanks to this new global rule.
If you would like to test the correctness of this rule on the home page of this CMP, let me tell you right away that the banner there is displayed with a delay of more than 5 seconds, and as a result, it slips unnoticed by the cookie presence detector. Other websites on which I have tested this rule do not seem to have such a delay.
One important thing to note is that interacting with this banner during its fade-in animation may cause it to get stuck in a semi-transparent state for some time (see attached screenshot below), after which it should disappear very very slowly. It all depends on when the interaction with the cookie accept/reject button occurs. If it happens during the animation, the banner will remain semi-transparent for some time and then disappear. However, if it happens after the animation is over, the banner will then close as expected. Of course, such banner can then be waited out or closed manually, but this defeats the purpose of the automatic cookie blocker in Firefox. That's why I'm marking this PR as a draft, as I don't know what to do in this situation.
This is what the banner may look like after interrupting its animation:
Resolves #348
Resolves #467