Skip to content
This repository has been archived by the owner on Jan 7, 2025. It is now read-only.

Added a new global rule for CookieYes #357

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Greg-21
Copy link
Contributor

@Greg-21 Greg-21 commented Dec 6, 2023

When reviewing, please keep in mind that this is my first/one of the first attempts to make a global rule public and available to all users. I have done my best to test everything thoroughly on various websites, but I'm afraid that due to my lack of experience in this regard, I may have messed something up, and the rule will not work as expected (in some corner cases, for example).

In this pull request, I propose adding support for the CookieYes CMP, which is used in the wild by various websites on the Internet, and removing the site-specific rules that will no longer be necessary thanks to this new global rule.

Resolves #349

@Greg-21 Greg-21 requested a review from a team as a code owner December 6, 2023 15:30
@abhishekmadan30
Copy link
Contributor

Hi, please don't remove the site specific rules yet. Currently, in Fx120, the global rules are not enabled by default in private browsing mode in Germany. Global Rules will be released in Fx121 up until that point, we would like to leave in the site specific rules.

@Greg-21
Copy link
Contributor Author

Greg-21 commented Dec 6, 2023

Is it already set in stone that global rules will ride the trains in Firefox 121 stable (bug 1861377 only mentions beta)? If so, I wouldn't mind waiting to (eventually) merge this PR until Firefox 121 is released and gains adoption. Otherwise, I'm sure I'll forget to clean up after myself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CookieYes CMP is not supported
2 participants