Skip to content
This repository has been archived by the owner on Jan 7, 2025. It is now read-only.

Added a new global rule for Evidon #358

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Greg-21
Copy link
Contributor

@Greg-21 Greg-21 commented Dec 6, 2023

When reviewing, please keep in mind that this is my first/one of the first attempts to make a global rule public and available to all users. I have done my best to test everything thoroughly on various websites, but I'm afraid that due to my lack of experience in this regard, I may have messed something up, and the rule will not work as expected (in some corner cases, for example).

In this pull request, I propose adding support for the Evidon CMP, which is used in the wild by various websites on the Internet, and removing the site-specific rules that will no longer be necessary thanks to this new global rule.

Resolves #350

@Greg-21 Greg-21 requested a review from a team as a code owner December 6, 2023 17:40
@Trikolon
Copy link
Member

Trikolon commented Dec 7, 2023

Hi! Thanks for looking into more global / CMP rules! For visibility: #301 (comment)

@Greg-21
Copy link
Contributor Author

Greg-21 commented Dec 7, 2023

After sleeping on it, I've come to the conclusion that it's probably best to hold off on this pull request for now, as I'm afraid that there may be more websites like crunchyroll.com that use the #_evidon-decline-button ID with a cookie accept button, which in their opinion probably means something like "Do whatever you want, I don't care about cookies". I just hope there aren't many websites like theirs in the wild...

@Greg-21 Greg-21 marked this pull request as draft December 7, 2023 22:15
@Greg-21
Copy link
Contributor Author

Greg-21 commented Dec 7, 2023

Trikolon, thank you for making sure I'm aware of the potential complications, but since I've been using these global rules privately for a few weeks now, I have finally decided to publish them while I still have some free time. It's now or never :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evidon CMP is not supported
2 participants