This repository has been archived by the owner on Jan 7, 2025. It is now read-only.
Added a new rule for teamspeak.com #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admittedly, the cookie banner that is used on teamspeak.com should be supported after my PR #361 for the ihavecookies CMP is merged, but only partially, as that global rule only supports accepting cookies.
So, for teamspeak.com to be fully supported, something else needs to be done. Unfortunately, in the current implementation of the cookie banner blocker in Firefox, it is not possible to either:
Perhaps it will change in the future, but for now, in order to fully support this website, the only solution seems to be to create an almost identical rule to the one I already proposed in the other linked PR, but this time with support for injecting cookies.
Resolves #369