Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #249: Add EXCLUDE_URL_PREFIXES check #252

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

robhudson
Copy link
Member

@robhudson robhudson commented Jan 4, 2025

Check that EXCLUDE_URL_PREFIXES in settings is not a string.

If it is a string it can lead to a security issue where the string is treated as a list of characters, resulting in '/' matching all paths excluding the CSP header from all responses.

Copy link
Contributor

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, subtle footgun made safe

r+

@robhudson robhudson merged commit e9e4e27 into main Jan 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants