Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cirrus): Send enrollment key in a response #11860

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(cirrus): Send enrollment key in a response #11860

wants to merge 3 commits into from

Conversation

yashikakhurana
Copy link
Contributor

Because

  • We don't send back enrollment responses to the calling application and sometimes its hard to find if they are in the experiment or not

This commit

  • Return the enrollment data along with the features

Fixes #11814

@yashikakhurana
Copy link
Contributor Author

Blocked on #11819

jaredlockhart
jaredlockhart approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great! Thanks for getting through all these changes 🙏

cirrus/server/tests/test_main.py
@@ -508,18 +522,67 @@ def test_get_features_with_and_without_nimbus_preview(
],
}

# Without nimbus_preview
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each of these cases should really be their own individual test case rather than folded into one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, will split this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredlockhart jaredlockhart jaredlockhart approved these changes

@jeddai jeddai Awaiting requested review from jeddai jeddai is a code owner

Assignees
No one assigned
Labels
Blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cirrus returns the enrollment data in the response
2 participants
@yashikakhurana @jaredlockhart