Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hani/Stabilize test sap google adclick #339

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sv-hyacoub
Copy link
Collaborator

@sv-hyacoub sv-hyacoub commented Nov 20, 2024

Description

Stabilize test sap google adclick.

Bugzilla bug ID

Testrail:
Link:

Type of change

  • Other Changes (Please specify)

How does this resolve / make progress on that bug?

Fixed.

Screenshots / Explanations

N/A.

Comments / Concerns

N/A.

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/bsevct9uR0-TTOm29B-HyQ/Apvtt8QxRVuLVZRQLNNDVA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/bsevct9uR0-TTOm29B-HyQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/bsevct9uR0-TTOm29B-HyQ/Apvtt8QxRVuLVZRQLNNDVA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/bsevct9uR0-TTOm29B-HyQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2024-11-20T13:19:04.630Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/bsevct9uR0-TTOm29B-HyQ/Apvtt8QxRVuLVZRQLNNDVA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/bsevct9uR0-TTOm29B-HyQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/bsevct9uR0-TTOm29B-HyQ/Apvtt8QxRVuLVZRQLNNDVA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/bsevct9uR0-TTOm29B-HyQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2024-11-20T13:19:25.539Z

Copy link
Collaborator

@ben-c-at-moz ben-c-at-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you get your Linux machine up in time, this would be worth debugging there. If not, go ahead with the suggested xfail marker

@@ -13,7 +13,6 @@ def test_case():
return "1365108"


@pytest.mark.unstable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is failing in Linux, if you can't stabilize the test there, we can change the decorator to:

import platform
@pytest.mark.xfail(platform.system() == "Linux", reason="Telemetry testing unstable in Linux")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is failing on all OS's randomly if I run the test many times, sometimes search results don't return an ad and thats why the test can't see "search-result" locator.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In CI, it really looks like it's only failing in Linux--you're seeing fails in MacOS and Win?

Is there a way we can force there to be an ad, or re-run the check for SAP info multiple times without failing? Like run it 5 times and if it never gets anything it fails, but if it gets it once, it passes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally today the test passed everytime after running it up to 10 times on all 3 OS's, so I went with the first solution and mark it unstable on Linux.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge main into your branch. That should fix the Linux CI find toolbar test failure.

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/Zgj_uerpSFehCaOkeFIqZQ/WKHOYAkHQ-aMqhmwjGOD6A",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/Zgj_uerpSFehCaOkeFIqZQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/Zgj_uerpSFehCaOkeFIqZQ/WKHOYAkHQ-aMqhmwjGOD6A",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/Zgj_uerpSFehCaOkeFIqZQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2024-11-27T13:21:10.644Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants