change ternary expressions into if/else blocks for eslint 8

mozilla · Aug 5, 2024 · 9d9c44f · 9d9c44f
1 parent 5e01a6f
commit 9d9c44f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/frontend/src/components/dashboard/aliases/CustomAddressGenerationModal.tsx b/frontend/src/components/dashboard/aliases/CustomAddressGenerationModal.tsx
@@ -153,9 +153,11 @@ const CustomMaskCreator = (props: CustomMaskCreatorProps) => {
     event.preventDefault();
 
     const isValid = isAddressValid(address);
-    isValid
-      ? onPick(address.toLowerCase(), errorExplainerState.setOpen)
-      : errorExplainerState.setOpen(!isValid);
+    if (isValid) {
+      onPick(address.toLowerCase(), errorExplainerState.setOpen);
+    } else {
+      errorExplainerState.setOpen(!isValid);
+    }
   };
   const onChange: ChangeEventHandler<HTMLInputElement> = (event) => {
     setAddress(event.target.value);

diff --git a/frontend/src/pages/accounts/profile.page.tsx b/frontend/src/pages/accounts/profile.page.tsx
@@ -186,12 +186,13 @@ const Profile: NextPage = () => {
         setAliasGeneratedState(true);
       }
       addonData.sendEvent("aliasListUpdate");
-    } catch (error) {
+    } catch {
       // TODO: Refactor CustomAddressGenerationModal to remove the setAliasGeneratedState callback, and instead use a try catch block.
-      setAliasGeneratedState
-        ? setAliasGeneratedState(false)
-        : toast(l10n.getString("error-mask-create-failed"), { type: "error" });
-
+      if (setAliasGeneratedState) {
+        setAliasGeneratedState(false);
+      } else {
+        toast(l10n.getString("error-mask-create-failed"), { type: "error" });
+      }
       // This is so we can catch the error when calling createAlias asynchronously and apply
       // more logic to handle when generating a mask fails.
       return Promise.reject("Mask generation failed");