Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Hide alert bar on navigation to remove recovery phone #18578

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

vpomerleau
Copy link
Contributor

@vpomerleau vpomerleau commented Mar 20, 2025

Because

  • Alerts were staying on screen and not dismissed on delete button click

This pull request

  • Explicitly hide the alert

Issue that this pull request solves

Closes: FXA-11110

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@vpomerleau vpomerleau requested a review from a team as a code owner March 20, 2025 17:31
Because:

* Alerts were staying on screen and not dismissed on delete button click

This commit:

* Explicitely hide the alert

Closes #FXA-11110
Copy link
Contributor

@chenba chenba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:disappear:

@vpomerleau vpomerleau merged commit 406efff into main Mar 24, 2025
23 checks passed
@vpomerleau vpomerleau deleted the FXA-11110-b branch March 24, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants