fix(settings): Redirect from React email first with email param #18579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpomerleau
force-pushed
the
FXA-11327
branch
2 times, most recently
from
832d49a to
0b6cfad
Compare
dschom
reviewed
Mar 21, 2025
| // We can also use useNavigateWithQuery after addressing the above. | ||
| params.delete('email'); | ||
| const hasParams = params.size > 0; | ||
| const isOAuth = location.pathname.startsWith('/oauth'); |
There was a problem hiding this comment.
Should this use the isOauthIntegration(integration) instead?
dschom
reviewed
Mar 21, 2025
dschom
reviewed
Mar 21, 2025
dschom
reviewed
Mar 21, 2025
dschom
reviewed
Mar 21, 2025
| console.log( | ||
| `${signupRoute}${hasParams ? `?${params.toString()}` : ''}` | ||
| ); | ||
| navigate(`${signupRoute}${hasParams ? `?${params.toString()}` : ''}`, { |
There was a problem hiding this comment.
If params is empty, toString() will result in '' anyway, so I don't see the need for the ternary operator.
There was a problem hiding this comment.
Updated to use the URL API instead of this ternary.
Because: * Navigating to react email first with an email param was causing an infinite redirect This commit: * If an email is provided, check email status and redirect appropriately to signin or signup Closes #FXA-11327
dschom
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-11327
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Container tests will be added in follow-up
FXA-11316