Ping Annotations #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on the exact same principle as metric annotations. This PR changes the API format slightly, so we'll need to modify the glean dictionary as well before this lands.
3 tasks
acmiyaguchi
approved these changes
Mar 29, 2021
|
|
||
| ANNOTATIONS_DIR = os.path.join(os.path.dirname(__file__), "..", "annotations") | ||
|
|
||
| data = defaultdict(lambda: defaultdict(lambda: {})) |
There was a problem hiding this comment.
It might be worthwhile to create a schema to validate the API:
type: object
description: application
additionalProperties:
type: object
description: metric/ping
additionalProperties:
type: object
properties:
content:
type: string
description: markdown contents of annotation
component:
type: string
$comment: could be an enumerated type
features:
type: string
required:
- contentThere was a problem hiding this comment.
Great idea! Filed #9 for this
|
Waiting for review on mozilla/glean-dictionary#493 before merging this: they mutually depend on each other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.