Do not ignore subfolder with name equal to root #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-c
reviewed
Dec 16, 2020
marco-c
reviewed
Dec 16, 2020
Before this commit, a subfolder with the same name as the root/source folder would be ignored from the coverage reports (see #483). This was occurring because the ancestor of the subfolder was being pruned (because it matched the end of the source folder) in the method used to guess the absolute path. This resulted in an incorrect guess of the absolute path. With this commit, we first check whether the join of the subfolder relative path with the source folder exists, and if so, return it as the guess of the absolute path. If the join doesn't exist, we use the previous guess method.
|
@marco-c I've addressed your comments. (I force-pushed as the diff is small.) |
marco-c
reviewed
Dec 16, 2020
marco-c
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, a subfolder with the same name as the root/source folder would be ignored from the coverage reports (see #483). This was occurring because the ancestor of the subfolder was being pruned (because it matched the end of the source folder) in the method used to guess the absolute path. This resulted in an incorrect guess of the absolute path.
With this commit, we first check whether the join of the subfolder relative path with the source folder exists, and if so, return it as the guess of the absolute path. If the join doesn't exist, we use the previous guess method.