Skip to content

Commit

Permalink
Fix join generation for metric views (#1144)
Browse files Browse the repository at this point in the history
* Fix join generation for metric views

* Fix condition logic
  • Loading branch information
scholtzan authored Jan 14, 2025
1 parent ae73de2 commit d18e97d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions generator/views/metric_definitions_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ def to_lookml(self, v1_name: Optional[str], dryrun) -> Dict[str, Any]:

if (
data_source_definition.client_id_column == "NULL"
or data_source_definition.columns_as_dimensions
):
and not base_view_dimensions
) or data_source_definition.columns_as_dimensions:
# if the metrics data source doesn't have any joins then use the dimensions
# of the data source itself as base fields
date_filter = None
Expand Down

0 comments on commit d18e97d

Please sign in to comment.