Change backpack Persona usage to the Observer API #511
Comments
ghost
assigned 
|
I did a spike on this in stenington/openbadges@observer-stash, which @toolness has added his comments to. The spike needs to be reworked into a proper pull request at this point, but it seems like all the moving pieces are there. The spike code is live at http://stenington.org:8888 as well. |
|
Aaaaaand we have a problem: mozilla/persona#2999 @cmcavoy: @andrewhayward uncovered this while trying to take over this bug. With 3rd party cookies disabled, the Observer API repeatedly kicks you out of the app immediately after login. |
|
Looks like we might be able to detect this setting and warn users or suggest whitelisting persona: http://stackoverflow.com/questions/3550790/check-if-third-party-cookies-are-enabled/7104048#7104048 |
I don't like the inline JS in the page, but the existing logic in static/js/badge-accept/badge-accept.js is pretty coupled to the issuer frame, and we're going to be migrating to use the observer API in mozilla#511 anyways, so the code will likely be pretty temporary.
|
It looks like our blocking persona bug was fixed by mozilla/persona@013b48c. That said, one of the new things we've added since filing this bug and making stenington/openbadges@observer-stash is the nifty test infrastructure in df88c31, which stubs out |
|
Can this please be added this week |
|
Hi @satdav, I'm sorry but this won't be able to be added for a while, the core open badges team is working on another project right now. If you can submit a pull request, that would speed it up considerably! Thanks... |
Change over the badge acceptance flow to use the Persona Observer API. The
returnTofor now should probably just be the index page, although this will pave the way for some fancy "Welcome to the Backpack" sort of thing.The text was updated successfully, but these errors were encountered: