Skip to content

Commit

Permalink
Remove skip metric hacks
Browse files Browse the repository at this point in the history
Fixes #697
  • Loading branch information
badboy committed Apr 8, 2024
1 parent d3400fe commit d51d879
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions probe_scraper/glean_checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,6 @@

from .scrapers.git_scraper import Commit

# Ugly hack to skip certain metrics which we know aren't duplicated,
# but show up duplicated due to them being moved from one
# to the other application/library.
SKIP_METRICS = {
"gecko.version": ["gecko", "pine", "firefox-desktop"],
"gecko.build_id": ["gecko", "pine", "firefox-desktop"],
}


def _metric_sort_key(metric: Dict[str, Any]):
return (
Expand Down Expand Up @@ -151,11 +143,6 @@ def check_for_duplicate_metrics(repositories, metrics_by_repo, emails):
# avoid false positive duplication accross app channels.
v = [dep for dep in v if "engine-gecko" not in dep]

if k in SKIP_METRICS.keys():
potential_deps = SKIP_METRICS[k]
if any([dep for dep in potential_deps if dep in v]):
continue

if len(v) > 1:
duplicate_sources[k] = v

Expand Down

0 comments on commit d51d879

Please sign in to comment.