Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fog-updater: Fix some issues. #829

Merged
merged 5 commits into from
Jan 10, 2025
Merged

fog-updater: Fix some issues. #829

merged 5 commits into from
Jan 10, 2025

Conversation

badboy
Copy link
Member

@badboy badboy commented Nov 7, 2024

Every commit documents the changes on its own

@badboy badboy requested a review from chutten November 7, 2024 09:59
@badboy badboy force-pushed the dont-fail-on-noop branch from bef3af5 to 4c6efc2 Compare January 9, 2025 11:02
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me reads the pygithub and gh rest API docs for what requested_reviewers does.

Ah, not needed because we auto-apply all the reviewers on PR creation? Very good.

@chutten
Copy link
Contributor

chutten commented Jan 9, 2025

(which is indeed what your commit message says, but github makes it so hard to see commit messages (gosh, even commit subjects take effort to locate) that I didn't think to look until after combing through the docs)

@badboy badboy merged commit 9482795 into main Jan 10, 2025
2 checks passed
@badboy badboy deleted the dont-fail-on-noop branch January 10, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants