Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Suport RTL for testpilot FrontEnd #1906

Closed
mohamed7afezz opened this issue Dec 3, 2016 · 4 comments
Closed

Suport RTL for testpilot FrontEnd #1906

mohamed7afezz opened this issue Dec 3, 2016 · 4 comments

Comments

@mohamed7afezz
Copy link

mohamed7afezz commented Dec 3, 2016

We almost finished Arabic localization for testpilot website, as part of planning for Arabic Identity of Test Pilot Activity and RTL bugs is here.

Home page have 3 main issues with RTL languages:

  1. In card-list section, Cards need to margin-left with zero and margin-left with 40px

untitled2

  1. In newsletter-footer section, background image "email pic" need to change position to right and change the header margin to left

untitled1

  1. In main-footer section, margin for mozilla-logo need be change to left and margin for social-links need to change to the right

untitled33

Experiments page have 2 main issues with RTL languages:

  1. In testpilot-promo section, the legal-information paragrapher need to text-align to right

untitled4

  1. In contributors section, contributor div need to text-align to right and change the padding to right

untitled5

In addition to the 3 main issues that appear in Home page

@johngruen
Copy link
Contributor

@mohamed7afezz we should do this! I'd like to make sure we hit small viewport sizes correctly as well though. Would you mind taking a look at errors you see there as well?

@johngruen johngruen added this to the Sprint 16 milestone Dec 16, 2016
@ghost ghost removed this from the Sprint 16 milestone Jan 9, 2017
@johngruen
Copy link
Contributor

I think we could reasonably pick this up with any photon redesign we do.

@ghost ghost added the status: planned label Jul 24, 2017
@ghost ghost added this to the Stretch milestone Sep 18, 2017
@meandavejustice
Copy link
Contributor

meandavejustice commented May 9, 2018

Came across this article today on mdn which looks pretty helpful. I think the way forward is to detect whether or not the user is using a rtl lang, and set the dir attribute on the html document and target it with html[dir="ltr"] selector in our css. We don't have a terrible amount of text surface area, so I think it's reasonable to target these areas in our own css rather than trying to use something like https://github.com/twitter/css-flip which may just cause further problems for us.

@johngruen thoughts?

@meandavejustice
Copy link
Contributor

Additionally, based on manually testing for ar on testpilot prod site, we aren't supporting arabic right now. Maybe our translation percentage fell below the threshhold at some point?

@meandavejustice meandavejustice self-assigned this May 14, 2018
meandavejustice pushed a commit to meandavejustice/testpilot that referenced this issue May 14, 2018
- fixes mozilla#1906
- footer fixes were not addressed because footer is in process of being updated,
will need a rtl review once mozilla#3550 is merged.
- experiment page has changed recently, from my reviews it appears that all of
the referened issues have been addressed already.
meandavejustice pushed a commit that referenced this issue May 22, 2018
- fixes #1906
- footer fixes were not addressed because footer is in process of being updated,
will need a rtl review once #3550 is merged.
- experiment page has changed recently, from my reviews it appears that all of
the referened issues have been addressed already.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants