This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Some tweaks to better support rtl #3551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes mozilla#1906 - footer fixes were not addressed because footer is in process of being updated, will need a rtl review once mozilla#3550 is merged. - experiment page has changed recently, from my reviews it appears that all of the referened issues have been addressed already.
Codecov Report
@@ Coverage Diff @@
## master #3551 +/- ##
==========================================
- Coverage 82.07% 82.02% -0.06%
==========================================
Files 110 110
Lines 2935 2937 +2
==========================================
Hits 2409 2409
- Misses 526 528 +2
Continue to review full report at Codecov.
|
dannycoates
approved these changes
May 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will need a rtl review once Photonize footer #3550 is merged.
the referened issues have been addressed already.