Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application field to the PerfCompare endpoint response #7782

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

beatrice-acasandrei
Copy link
Collaborator

@beatrice-acasandrei beatrice-acasandrei commented Aug 28, 2023

In order to display the application in PerfCompare we need to update the endpoint to provide this information for base and new values.

For testing:
Staging vs Local response from the PerfCompare endpoint - connected to the staging db

@beatrice-acasandrei beatrice-acasandrei force-pushed the add-application-to-perfcompare-api branch 2 times, most recently from 3694af9 to b76faec Compare August 28, 2023 16:43
@alexandru-io
Copy link
Contributor

alexandru-io commented Aug 31, 2023

In order to display the application in PerfCompare we need to update the endpoint to provide this information for base and new values.

For testing: Staging vs Local response from the PerfCompare endpoint - connected to the staging db

You're providing a link to compare view (which you haven't touched in the PR as far as I can tell) and an API response from PerCompare from localhost. I am pulling the 2 compared commits from mozilla-central to see the response locally. Is the compare view link relevant?

Copy link
Contributor

@alexandru-io alexandru-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm sorry, I must have pressed something and closed your PR by mistake.)

Here, the results from my localhhost:
image

@beatrice-acasandrei
Copy link
Collaborator Author

In order to display the application in PerfCompare we need to update the endpoint to provide this information for base and new values.
For testing: Staging vs Local response from the PerfCompare endpoint - connected to the staging db

You're providing a link to compare view (which you haven't touched in the PR as far as I can tell) and an API response from PerCompare from localhost. I am pulling the 2 compared commits from mozilla-central to see the response locally. Is the compare view link relevant?

The response from the PerfCompare endpoint should contain the data that is being displayed on Perfherder's Compare View.

@beatrice-acasandrei
Copy link
Collaborator Author

@Archaeopteryx I would like to merge this. Do you know when that will be possible since ci/circleci: python-tests-postgres is currently failing?

@Archaeopteryx
Copy link
Collaborator

The failure should be resolved if the patch gets rebased on latest master.

@beatrice-acasandrei beatrice-acasandrei force-pushed the add-application-to-perfcompare-api branch from c153295 to 65ae43b Compare September 14, 2023 14:07
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0730051) 76.81% compared to head (65ae43b) 76.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7782   +/-   ##
=======================================
  Coverage   76.81%   76.82%           
=======================================
  Files         537      537           
  Lines       26518    26524    +6     
  Branches     3354     3354           
=======================================
+ Hits        20371    20377    +6     
  Misses       5982     5982           
  Partials      165      165           
Files Changed Coverage Δ
tests/conftest.py 95.62% <ø> (ø)
treeherder/webapp/api/performance_data.py 92.29% <ø> (ø)
tests/webapp/api/test_perfcompare_api.py 79.48% <100.00%> (+0.53%) ⬆️
treeherder/webapp/api/performance_serializers.py 97.28% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archaeopteryx Archaeopteryx removed their request for review September 14, 2023 15:12
@Archaeopteryx Archaeopteryx merged commit 1cc3a5e into master Sep 14, 2023
1 check passed
@Archaeopteryx Archaeopteryx deleted the add-application-to-perfcompare-api branch September 14, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants