-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add application field to the PerfCompare endpoint response #7782
Conversation
3694af9
to
b76faec
Compare
You're providing a link to compare view (which you haven't touched in the PR as far as I can tell) and an API response from PerCompare from localhost. I am pulling the 2 compared commits from mozilla-central to see the response locally. Is the compare view link relevant? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The response from the PerfCompare endpoint should contain the data that is being displayed on Perfherder's Compare View. |
@Archaeopteryx I would like to merge this. Do you know when that will be possible since |
The failure should be resolved if the patch gets rebased on latest master. |
c153295
to
65ae43b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7782 +/- ##
=======================================
Coverage 76.81% 76.82%
=======================================
Files 537 537
Lines 26518 26524 +6
Branches 3354 3354
=======================================
+ Hits 20371 20377 +6
Misses 5982 5982
Partials 165 165
☔ View full report in Codecov by Sentry. |
In order to display the application in PerfCompare we need to update the endpoint to provide this information for base and new values.
For testing:
Staging vs Local response from the PerfCompare endpoint - connected to the staging db