Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove analytics from 40x and 50x templates #274

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Remove analytics from 40x and 50x templates #274

merged 2 commits into from
Jan 22, 2024

Conversation

stevejalim
Copy link
Collaborator

@stevejalim stevejalim commented Jan 9, 2024 •
edited
Loading

Description

Stop loading analytics JS on 403 and 404 pages

  • I have manually tested this.
  • I have recorded this change in CHANGELOG.md.

Issue

Resolves #261

Testing

  • Set DEBUG=False in your env
  • npm run build
  • just collectstatic
  • ./birdbox/manage.py runserver`
  • Go to localhost:8000/kjhsdflkahgfl and view source see there is no reference to /static/js/analytics.... in the 404 page. Compare with localhost:8000 where it still will mentioned

@stevejalim stevejalim changed the title 261 remove analytics from 40x and 50x templates Remove analytics from 40x and 50x templates Jan 10, 2024
craigcook
craigcook approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈

@craigcook craigcook merged commit 669c1ef into main Jan 22, 2024
2 checks passed
@craigcook craigcook deleted the 261-remove-analytics-from-40x-and-50x-templates branch January 22, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigcook craigcook craigcook approved these changes

@robhudson robhudson Awaiting requested review from robhudson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop analytics JS from 40x and 50x pages
2 participants
@stevejalim @craigcook