Provides SPM Support for Appetitive Integration. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterjenkins Gymshark required this integration via SPM. Hope this helps others. Thanks @bolshedvorsky for the work. |
…ns/mparticle-apple-integration-apptentive into mparticle-integrations-development # Conflicts: # mParticle-Apptentive/MPKitApptentive.m
Mparticle integrations development
frankus
reviewed
Feb 9, 2023
| @@ -270,10 +268,14 @@ - (nonnull MPKitExecStatus *)logBaseEvent:(nonnull MPBaseEvent *)event { | |||
|
|
|||
| - (MPKitExecStatus *)routeEvent:(MPEvent *)event { | |||
| NSDictionary *eventValues = event.customAttributes; | |||
|
|
|||
| UIViewController * rootViewController = [[[[UIApplication sharedApplication] delegate] window] rootViewController]; | |||
There was a problem hiding this comment.
I might be missing something, but this case should already be handled by the Apptentive SDK.
Passing nil results in a nil presentingViewController property on the InteractionPresenter instance (see https://github.com/apptentive/apptentive-kit-ios/blob/97ba45ba650f742be956a5e33fc1c4f31a626574/Sources/ApptentiveKit/Interactions/InteractionPresenter.swift#L168), which will walk up the view controller stack of the application's keyWindow. It also handles the (surprisingly common) case where an interaction tries to present on a view controller that is being dismissed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Package.swift file for SPM support
Fixes
from: viewControllerbeing nil.Testing Plan
Integration with SPM