Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Clevertap SDK to Version 5.x #11

Merged
merged 2 commits into from
Dec 13, 2023
Merged

feat: Update Clevertap SDK to Version 5.x #11

merged 2 commits into from
Dec 13, 2023

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • Update to use Clevertap 5.x

Testing Plan

  • Confirmed locally and tested end to end for a day (didn't see any problems) until I seemed to get locked out of our clevertap account.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Dec 6, 2023
einsteinx2
einsteinx2 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samdozor
samdozor approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@samdozor samdozor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming - did you check that we aren't using any of the newly deprecated APIs in 5.x? if so, lgtm

@BrandonStalnaker
Copy link
Contributor Author

@samdozor I confirmed we weren't using any of these https://github.com/CleverTap/clevertap-ios-sdk/blob/master/CHANGELOG.md#deprecated and didn't notice any new warnings.

@BrandonStalnaker BrandonStalnaker merged commit 409ee8a into development Dec 13, 2023
3 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/5877-Update-Clevertap-To-Latest branch December 13, 2023 17:54
@einsteinx2 einsteinx2 mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdozor samdozor samdozor approved these changes

@einsteinx2 einsteinx2 einsteinx2 approved these changes

Assignees

@BrandonStalnaker BrandonStalnaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrandonStalnaker @einsteinx2 @samdozor