Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set custom SDK name and version on CleverTap #13

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

einsteinx2
Copy link
Contributor

Summary

  • Set custom SDK name and version on CleverTap (based on PR from CleverTap: chore: Update clevertap ios sdk to v5.x #12)
  • Switched from Carthage to CocoaPods for the unit test project
  • Updated the release script to set the version number constant on release

Testing Plan

  • Added comprehensive unit test on the version string to int conversion method
  • Confirmed that the release script correctly updates the version constant

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@einsteinx2 einsteinx2 force-pushed the feat/6055-set-custom-sdk-info branch from 2e5f596 to 108cb09 Compare January 5, 2024 21:16
@akashvercetti
Copy link

@einsteinx2 @BrandonStalnaker looks good 👍

Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit f80027c into development Jan 8, 2024
3 checks passed
@einsteinx2 einsteinx2 deleted the feat/6055-set-custom-sdk-info branch January 8, 2024 16:16
mparticle-automation added a commit that referenced this pull request Jan 8, 2024
# [8.3.0](v8.2.0...v8.3.0) (2024-01-08)

### Features

* Set custom SDK name and version on CleverTap ([#13](#13)) ([f80027c](f80027c))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 8.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants