Address PR Comments

mparticle-integrations · Sep 25, 2024 · c50b73c · c50b73c
1 parent 5605bf3
commit c50b73c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 12 deletions.
diff --git a/src/BingAdsEventForwarder.js b/src/BingAdsEventForwarder.js
@@ -46,14 +46,12 @@ var constructor = function() {
     self.name = name;
 
     function initForwarder(settings, service, testMode) {
-        console.warn('BING Local DEV');
-
         forwarderSettings = settings;
         reportingService = service;
 
-        if (forwarderSettings.consentMapingWeb) {
+        if (forwarderSettings.consentMappingWeb) {
             self.consentMappings = parseSettingsString(
-                forwarderSettings.consentMapingWeb
+                forwarderSettings.consentMappingWeb
             );
         }
         self.consentPayloadDefaults = getConsentSettings(forwarderSettings);
@@ -89,7 +87,7 @@ var constructor = function() {
                             };
                             (obj.q = window[queue]),
                                 (window[queue] = new UET(obj)),
-                                maybeSendConsentUpdateToBing(consentPayload);
+                                maybeSendConsentUpdateToBing(updatedConsentPayload);
                             window[queue].push('pageLoad');
                         }),
                         (n = document.createElement(tag)),
@@ -122,7 +120,6 @@ var constructor = function() {
             isInitialized = true;
             return 'Successfully initialized: ' + name;
         } catch (e) {
-            console.log('error?');
             return "Can't initialize forwarder: " + name + ': ' + e;
         }
     }

diff --git a/test/src/tests.js b/test/src/tests.js
@@ -254,7 +254,7 @@ describe('Bing Ads Event Forwarder', function() {
             mParticle.forwarder.init(
                 {
                     tagId: 'tagId',
-                    consentMapingWeb:
+                    consentMappingWeb:
                         '[{&quot;jsmap&quot;:null,&quot;map&quot;:&quot;Marketing&quot;,&quot;maptype&quot;:&quot;ConsentPurposes&quot;,&quot;value&quot;:&quot;ad_storage&quot;}]',
                 },
                 reportService.cb,
@@ -283,7 +283,7 @@ describe('Bing Ads Event Forwarder', function() {
             mParticle.forwarder.init(
                 {
                     tagId: 'tagId',
-                    consentMapingWeb: JSON.stringify(consentMap),
+                    consentMappingWeb: JSON.stringify(consentMap),
                     defaultAdStorageConsentWeb: 'Denied', // Should be overridden by user consent state
                 },
                 reportService.cb,
@@ -357,7 +357,7 @@ describe('Bing Ads Event Forwarder', function() {
             mParticle.forwarder.init(
                 {
                     tagId: 'tagId',
-                    consentMapingWeb: JSON.stringify(consentMap),
+                    consentMappingWeb: JSON.stringify(consentMap),
                     defaultAdStorageConsentWeb: 'Unspecified', // Should be overridden by user consent state
                 },
                 reportService.cb,
@@ -383,7 +383,7 @@ describe('Bing Ads Event Forwarder', function() {
             mParticle.forwarder.init(
                 {
                     tagId: 'tagId',
-                    consentMapingWeb: JSON.stringify(consentMap),
+                    consentMappingWeb: JSON.stringify(consentMap),
                 },
                 reportService.cb,
                 false // Disable testMode so we can test init
@@ -459,7 +459,7 @@ describe('Bing Ads Event Forwarder', function() {
             mParticle.forwarder.init(
                 {
                     tagId: 'tagId',
-                    consentMapingWeb: JSON.stringify(consentMap),
+                    consentMappingWeb: JSON.stringify(consentMap),
                     defaultAdStorageConsentWeb: 'Denied',
                 },
                 reportService.cb,
@@ -536,7 +536,7 @@ describe('Bing Ads Event Forwarder', function() {
             mParticle.forwarder.init(
                 {
                     tagId: 'tagId',
-                    consentMapingWeb: JSON.stringify(consentMap),
+                    consentMappingWeb: JSON.stringify(consentMap),
                 },
                 reportService.cb,
                 false // Disable testMode so we can test init