fixed from PVS-Studio:

V575 The number of processed elements should be passed to the 'GetWindowTextW' function as the third argument instead of buffer's size in bytes. dockingdlginterface.h 44 V773 Visibility scope of the 'nPtr' pointer was exited without releasing the memory. A memory leak is possible. globals.cpp 100
mpcabd · Oct 30, 2017 · 60a98a5 · 60a98a5
1 parent 83d3d1b
commit 60a98a5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/DockingFeature/DockingDlgInterface.h b/DockingFeature/DockingDlgInterface.h
@@ -41,7 +41,7 @@ class DockingDlgInterface : public StaticDialog
 
     void create(tTbData * data, bool isRTL = false){
 		StaticDialog::create(_dlgID, isRTL);
-		::GetWindowText(_hSelf, _pluginName, sizeof(_pluginName));
+		::GetWindowText(_hSelf, _pluginName, sizeof(_pluginName)/sizeof(TCHAR));
 
         // user information
 		data->hClient		= _hSelf;

diff --git a/globals.cpp b/globals.cpp
@@ -97,6 +97,8 @@ wstring GetPythonPath() {
 				pythonInstalled = true;
 				break;
 			}
+
+			delete[] nPtr;
 		} while (FindNextFile(h, &data));
 	}
-Original file line number
+Diff line change
@@ Expand Up / @@ -97,6 +97,8 @@ wstring GetPythonPath() { @@
     				pythonInstalled = true;
     				break;
     			}
+    			delete[] nPtr;
     		} while (FindNextFile(h, &data));
     	}
@@ Expand Down @@