Fixes #171: exposes the auth, username and password properties of registries #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of registries.
mpetuska
approved these changes
Jul 1, 2024
|
Seems I only ran the tests, not the full check suite. Will fix that later today, hopefully. |
|
could you run |
auto-merge was automatically disabled
July 1, 2024 18:47
Head branch was pushed to by a user without write access
|
Done! |
mpetuska
approved these changes
Jul 1, 2024
|
Thanks for the PR! |
|
No problem! When do you think this will be released? |
lesteenman
deleted the
expose-additional-authentication-options-of-registries
branch
|
hoping for friday |
|
Hi @mpetuska ! Would you mind releasing a new version of the plugin with these changes? I'd really like to use Thank you! (And thanks @lesteenman for implementing them 😄) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes a couple of extra authentication related properties of npm registry configuration.
I opted not to throw any exceptions if multiple options were found, but instead rely on the behaviour of NPM itself, and to transparently pass the parameters on.
The only field with special changes needed is the
_passwordfield, which npm expects to have been set as a base64 encoded string in the.npmrcfile. I've transparently exposed the password field to the plugin's users to simplify usage, but encoded it in the plugin.I haven't found official documentation about that, but was inspired by this line in the official npm github repository: https://github.com/npm/cli/blob/3b8b11161ee2f88817dcc19b4770040d5bc73261/workspaces/arborist/README.md?plain=1#L42