Add some detailed explanation about movementX/Y support #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpizenberg
requested changes
Jun 20, 2023
There was a problem hiding this comment.
Thanks for your PR!
I've made small changes suggestions, then it's good to merge.
I'd have committed the changes myself, but the fact your PR comes from your main branch makes it just slighly more annoying because I can't just git checkout your-branch-name and have it auto pull-push from your repo. So I made the suggestions via github interface instead ^^
Co-authored-by: Matthieu Pizenberg <[email protected]>
|
I have added all the changes requested 👍 |
|
Awesome! |
|
Hi, @mpizenberg, it's almost next week 😉 |
|
Ahah, I can't argue with that ^^.
I'm travelling for two weeks but will have a look again after that. Sorry
…On Sat, May 11, 2024, 10:52 Vít Brunner ***@***.***> wrote:
Hi, @mpizenberg <https://github.com/mpizenberg>, it's almost next week 😉
—
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWFOCOHRSRBPP546E2Y2J3ZBXL6FAVCNFSM6AAAAAAZNJC262VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGY2DCMRWGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hello from the past 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in #29 I added some details about
movementX/Ysupport