Added md5 checks for 5 models downloaded from outside of the repo #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
anna-stacey
commented
Nov 18, 2022
anna-stacey
commented
- Added md5 checking to 5 model files: fairseq glossing, fairseq segmentation, and 3 coling models (cls, dumb, smart).
- Also ensured all 5 of these files download from online (i.e. I removed the 3 coling models from the repository - the other two already worked this way).
- The md5 checking materials are stored in a new config directory in the root directory.
- The md5 checks only occur when the models have just been downloaded.
- The coling md5 checks are not very well-tested at this point because this part of the code is not running at present.
…iles from google drive). - Also fixed a typo.
… for the fairseq gloss model). - Created a .csv which will store expected MD5 values for model files that will be downloaded separately from the rest of the repo. - Created a python file that checks the actual MD5 against the expected value as found in the .csv. This python file is called by the entrypoint.sh script right after the relevant model file is downloaded.
…tored in the .csv).
…gle drive account. - This means the files will no longer be stored in the repo.
- Changed to using more descriptive model-identifying names. - Added more descriptive error messages to the MD5-checking code - it now lets you know if the actual MD5 matches ANOTHER MD5 value in the csv (other than the expected one).
- Issue: had to create two copies of MD5 checking files until I can figure out how to keep them both in a common config file in the root directory. - Ideally should be tested further once we can run the coling models from the GUI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.