Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "input: allow input.conf bindings to be declared as builtin" #15347

Closed
wants to merge 1 commit into from

Conversation

guidocella
Copy link
Contributor

This reverts commit 70ff543.

This never did anything because mp_input_load_config() always already called parse_config() with builtin = true for builtin_input_conf. And we already have compatibility input.conf files without depending on this line. So unless someone can decipher what wm4 meant, it can be removed.

This reverts commit 70ff543.

This never did anything because mp_input_load_config() always already
called parse_config() with builtin = true for builtin_input_conf. And we
already have compatibility input.conf files without depending on this
line. So unless someone can decipher what wm4 meant, it can be removed.
@guidocella guidocella marked this pull request as ready for review November 21, 2024 17:18
@na-na-hi
Copy link
Contributor

This never did anything because mp_input_load_config() always already called parse_config() with builtin = true for builtin_input_conf.

This is incorrect. For key bindings loaded from config files rather than builtin_input_conf, this makes the bindings treated as builtin so they have lower priority compared to non-builtin bindings.

@guidocella
Copy link
Contributor Author

Ok but we don't have any such config file with that line.

@na-na-hi
Copy link
Contributor

It can be defined in user's config files.

@guidocella
Copy link
Contributor Author

But why would someone do that? It's not even documented.

@na-na-hi
Copy link
Contributor

na-na-hi commented Nov 21, 2024

But why would someone do that?

It has valid uses. For example, a mpv plugin or script can redefine builtin key bindings, without needing to recompile mpv, while still allowing user bindings in input.conf take preference. It allows changing player key bindings in a less agressive way.

@guidocella guidocella closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants