Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows: switch from pkg-config to pkgconf for macOS and Ubuntu mingw-w64 #15349

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

jeeb
Copy link
Member

@jeeb jeeb commented Nov 21, 2024

Latter is now available, and pkg-config as a package has been deprecated.

Additionally, attempt to work around recent GHA image breakage.

@jeeb jeeb added the os:mac label Nov 21, 2024
@jeeb jeeb force-pushed the macos_ci_unlink_pkg_config branch 7 times, most recently from 5d2e554 to 4de21de Compare November 21, 2024 22:46
Copy link

github-actions bot commented Nov 21, 2024

Download the artifacts for this pull request:

Windows
macOS

jeeb added 3 commits November 22, 2024 19:43
Is now available, and pkg-config as a package has been deprecated.
This works around an issue with recent Github CI runners where
Homebrew is in an intermediate state. This is where old pkg-config
is installed, yet pkg-config as a package has become an alias
for pkgconf, thus causing failures to automatically switch symlinks
from one to the other.

Ref: actions/runner-images#10984
Ubuntu 24.04's pkg-config is already an almost empty transitional
package that depends on pkgconf, and pkgconf contains the
`/usr/bin/pkg-config` binary.

Thus while we are moving macOS to it, we shall do the same with
this mingw-w64 build.
@jeeb jeeb force-pushed the macos_ci_unlink_pkg_config branch from 4de21de to 7a55efb Compare November 22, 2024 17:52
@jeeb jeeb changed the title github/workflows: switch from pkg-config to pkgconf for macOS github/workflows: switch from pkg-config to pkgconf for macOS and Linux mingw-w64 Nov 22, 2024
@jeeb jeeb changed the title github/workflows: switch from pkg-config to pkgconf for macOS and Linux mingw-w64 github/workflows: switch from pkg-config to pkgconf for macOS and Ubuntu mingw-w64 Nov 22, 2024
As normal types started being supported better for type hinting,
their alternatives in the typing module would be deprecated.
@jeeb jeeb merged commit 7f49806 into mpv-player:master Nov 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant