fix: Fix issues on control & perception and improvement on handling control message. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kim-mins
commented
May 23, 2024
simulator/carla_autoware/README.md
Outdated
| @@ -127,7 +127,6 @@ The `carla_ros.py` sets up the CARLA world: | |||
| ## Tips | |||
|
|
|||
| - Misalignment might occurs during initialization, pressing `init by gnss` button should fix it. | |||
| - Changing the `fixed_delta_seconds` can increase the simulation tick (default 0.05 s), some sensors params in `objects.json` need to be adjusted when it is changed (example: LIDAR rotation frequency have to match the FPS). | |||
There was a problem hiding this comment.
After this commit, it seems we should fix the rotation_frequency.
There was a problem hiding this comment.
I think this tip should not be removed from the README.
There was a problem hiding this comment.
Thank you for the comment!
I agree to your point. I won't remove it.
maxime-clem
approved these changes
May 23, 2024
simulator/carla_autoware/README.md
Outdated
| @@ -127,7 +127,6 @@ The `carla_ros.py` sets up the CARLA world: | |||
| ## Tips | |||
|
|
|||
| - Misalignment might occurs during initialization, pressing `init by gnss` button should fix it. | |||
| - Changing the `fixed_delta_seconds` can increase the simulation tick (default 0.05 s), some sensors params in `objects.json` need to be adjusted when it is changed (example: LIDAR rotation frequency have to match the FPS). | |||
There was a problem hiding this comment.
I think this tip should not be removed from the README.
Kim-mins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here's the video for better description:
Tests performed
I respected the environment setting and followed testing steps written here.
Effects on system behavior
This resolves issue on oscillation and pointcloud range during the co-simulation using Carla, as the video above.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.