add: endianness option to scalar serde for Banderwagon #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you run the tests once after making these changes ? |
Yes, tests are fine. Since it is calling marshal and unmarshal internally, and they are tested, I hadn't added for a little endian scenario, but okay I will be adding. |
mratsim
reviewed
Jan 16, 2024
| @@ -130,19 +130,19 @@ func deserialize*(dst: var EC_Prj, src: array[32, byte]): CttCodecEccStatus = | |||
| ## Banderwagon Scalar Serialization | |||
| ## | |||
| ## ############################################################ | |||
| ## | |||
| func serialize_scalar*(dst: var array[32, byte], scalar: matchingOrderBigInt(Banderwagon)): CttCodecScalarStatus = | |||
| ## Adding an optional Endianness param default at BigEndian | |||
There was a problem hiding this comment.
procedure comments are below the procedure in Nim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an endianness param, set to BigEndian by default in Banderwagon scalar serde, using this because in the Verkle Spec sometimes conversion to and from in littleEndian byte arrays are also prevalent. In those cases, this provides a decent layer of abstraction for someone not knowing about the internals of Constantine.