Allow p.v subpatent infections #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwinskill
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Let's chat about this one @RJSheppard - I think we want to be careful not to imply things are not modelling in Pf, by the fact they are explicitly modelled in Pv
R/human_infection.R
Outdated
| k = parameters$klm, iaa = iaa, iam = iam) | ||
| patent_infections <- bitset_at(infections, bernoulli_multi_p(philm)) | ||
|
|
||
| incidence_renderer( |
There was a problem hiding this comment.
Might be worth chatting through this in person - I'm not clear what patent_incidence is really and how it would be used.
pwinskill
requested changes
Jul 15, 2024
RJSheppard
force-pushed
the
vivax_competing_hazards_main_remove_severe_immunity
branch
from
3662dca to
a06dc6c
Compare
RJSheppard
force-pushed
the
vivax_competing_hazards_main_subpatent_infections
branch
from
c892bc3 to
29b1fed
Compare
RJSheppard
force-pushed
the
vivax_competing_hazards_main_remove_severe_immunity
branch
from
a06dc6c to
5ff8fc6
Compare
RJSheppard
force-pushed
the
vivax_competing_hazards_main_subpatent_infections
branch
2 times, most recently
from
39949ff to
b8cce39
Compare
RJSheppard
force-pushed
the
vivax_competing_hazards_main_remove_severe_immunity
branch
from
5ff8fc6 to
e2580b4
Compare
RJSheppard
force-pushed
the
vivax_competing_hazards_main_subpatent_infections
branch
from
b8cce39 to
3472e76
Compare
RJSheppard
force-pushed
the
vivax_competing_hazards_main_remove_severe_immunity
branch
from
e2580b4 to
cd7ac4b
Compare
Base automatically changed from
vivax_competing_hazards_main_remove_severe_immunity
to
dev
October 11, 2024 08:58
RJSheppard
force-pushed
the
vivax_competing_hazards_main_subpatent_infections
branch
from
3472e76 to
bfe4c0a
Compare
giovannic
reviewed
Oct 11, 2024
…m-detectable and pcr-detectable infections, render these and schedule them. The P.v vignette has been extended to reflect these changes.
RJSheppard
force-pushed
the
vivax_competing_hazards_main_subpatent_infections
branch
from
bfe4c0a to
cb35f28
Compare
|
/benchmark |
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if cb35f28 is merged into dev:
Further explanation regarding interpretation and methodology can be found in the documentation. |
RJSheppard
deleted the
vivax_competing_hazards_main_subpatent_infections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p.v allows subpatent infections to occur, so we now calculate patent subpatent infections, render these and schedule them.