Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign names to all processes. #325

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Assign names to all processes. #325

merged 2 commits into from
Jul 25, 2024

Conversation

plietar
Copy link
Member

@plietar plietar commented Jul 12, 2024

Thanks to individual#198, processes in the simulation can now be named. This has no effect on the behaviour of the simulation but helps in debugging and profiling by labelling the call frames with the given names.

While at it, I've fixed a typo in the name of the prevalence renderer.

@plietar plietar requested a review from giovannic July 12, 2024 10:21
@giovannic
Copy link
Member

/benchmark

Copy link

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8363172 is merged into dev:

  • ✔️large_population: 2.11m -> 2.14m [-0.33%, +2.97%]
  • ✔️small_population: 32.7s -> 32.8s [-1.46%, +2.41%]

Further explanation regarding interpretation and methodology can be found in the documentation.
Plots and raw data are available as artifacts of the workflow run.

Thanks to [individual#198], processes in the simulation can now be
named. This has no effect on the behaviour of the simulation but helps
in debugging and profiling by labelling the call frames with the given
names.

[individual#198]: mrc-ide/individual#198
@plietar
Copy link
Member Author

plietar commented Jul 22, 2024

/benchmark

Copy link

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 52f4aa0 is merged into dev:

  • ✔️large_population: 2.15m -> 2.14m [-2.1%, +0.88%]
  • ❗🐌small_population: 32.2s -> 33.1s [+1.01%, +4.24%]

Further explanation regarding interpretation and methodology can be found in the documentation.
Plots and raw data are available as artifacts of the workflow run.

@plietar plietar merged commit 8bb953c into dev Jul 25, 2024
4 checks passed
@plietar plietar deleted the named-processes branch July 25, 2024 15:16
@giovannic giovannic mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants