Add a range check to bitset_index. #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function assumes the two bitsets are the same size, but was never checking for it. If the user passed in a second bitset that is smaller than the first, it could lead to an out-of-bounds access on the underlying std::vector.
plietar
force-pushed
the
bitset_index_bounds_check
branch
from
ffa1f4a to
4913f03
Compare
giovannic
approved these changes
Sep 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function assumes the two bitsets are the same size, but was never checking for it. If the user passed in a second bitset that is smaller than the first, it could lead to an out-of-bounds access on the underlying std::vector.