Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Bujumbura values #66

Merged
merged 12 commits into from
Feb 5, 2025
Merged

update Bujumbura values #66

merged 12 commits into from
Feb 5, 2025

Conversation

ruthmccabe
Copy link
Collaborator

…ources

@ruthmccabe ruthmccabe requested a review from lwhittles February 4, 2025 16:45
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.77%. Comparing base (e9664da) to head (31c59bf).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
R/parameters.R 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   88.74%   88.77%   +0.03%     
==========================================
  Files           8        8              
  Lines        1679     1684       +5     
==========================================
+ Hits         1490     1495       +5     
  Misses        189      189              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

R/parameters.R Outdated
} else if (region == "burundi"){
p_SW <- 0.028 * 0.5 # Laga et al
} else if (region == "bujumbura"){
p_SW <- 3852/(792503*0.5) ## key pops report, taken as median of Bujumbura Mairie in Figure 7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
p_SW <- 3852/(792503*0.5) ## key pops report, taken as median of Bujumbura Mairie in Figure 7
p_poss_SW <- sum(N_ASW + N_CSW)/ sum(N_age)
p_SW <- 3852 / (792503 * p_poss_SW) ## key pops report, taken as median of Bujumbura Mairie in Figure 7

This should be as a % of total pop right? we multiply by 0.5 above because the other figures are quoted as % of women engaging in SW
I think the suggestion above should make sure the total number of SW comes out at 3852 but please check!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run this it comes out as 3852 for ASWs + 1352 for CSWs = 5324 which is too high I think - should be 3852 overall no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK did some digging and I know why - we use the figure for Bujumbura Mairie for the SW prop but then the "total" bujumbura population also includes Isare. When I remove Isare this is all fine.
According to the KP document there are less SWs in Isare so we might have overinflated the value here, but I'm not sure how big a deal that is given the uncertainty in the SW size anyway @lwhittles

@lwhittles lwhittles merged commit 9dfa179 into main Feb 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants