Cast size_t to uint for Rf_error #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plietar
reviewed
Jun 19, 2024
inst/support.hpp
Outdated
| @@ -76,7 +76,7 @@ void user_check_array_dim(cpp11::sexp x, const char *name, | |||
| for (size_t i = 0; i < N; ++i) { | |||
| if (dim[(int)i] != dim_expected[i]) { | |||
| Rf_error("Incorrect size of dimension %d of '%s' (expected %d)", | |||
There was a problem hiding this comment.
Suggested change
| Rf_error("Incorrect size of dimension %d of '%s' (expected %d)", | |
| Rf_error("Incorrect size of dimension %zu of '%s' (expected %d)", |
Given that i has type size_t, %zu should be the portable way of printing it. If you do that then there's no need for a static_cast.
There was a problem hiding this comment.
Alternatively define i as an int in the for loop, then the cast in the line above can also be removed
There was a problem hiding this comment.
Thanks - I've gone for %zu as the minimal change - I'm not sure the reason for size_t over int here, but let's keep that and just fix the print warning...
plietar
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative fix for the issue Keith raised -
See https://mrc-ide.myjetbrains.com/youtrack/issue/mrc-5482/odin.dust-Rferror-type-warning
or teams programming chat...