Fix error while generating odin model #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error seen by Debbie - it's not terribly obvious at first:
this produces a length 2 logical where
deparse
returns a length 2 vector. We assume it won't do that because normally we use it on sensible calls. However we also use this in the generation phase where we just want to peek into the rhs to see which index variables (i
,j
,k
etc) we use and by that time we've rewritten binomial draws asbut here the "function name" (the thing called), is
OdinStochasticCall(sample = "binomial", mean = S_leave[i, j, k] * (S_rates[i, j, k, 1]/S_leave_rate[i, j, k]))
which flows onto two lines indeparse
...