Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype helper #1

Merged
merged 9 commits into from
Jul 6, 2023
Merged

Prototype helper #1

merged 9 commits into from
Jul 6, 2023

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Jul 6, 2023

This PR adds a prototype helper for bridging between orderly1 and orderly2; it requires merging vimc/orderly#327 and unpinning the branch (684460f) before merge. You must uninstall orderly before trying this out.

The idea is that we construct a little temporary package that imports, then reexports, all the functionality in the target package. There's a little check function to make sure that nothing too terrible happens with versions.

Once installed and run, then orderly::orderly_run will point at whatever version the user has requested - see the readme for details.

While this depends on the orderly1 rename, it can be reviewed before that winds to its eventual end

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@b839124). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head f70bae2 differs from pull request most recent head dadd4e5. Consider uploading reports for the commit dadd4e5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             main        #1   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         2           
  Lines           ?       103           
  Branches        ?         0           
========================================
  Hits            ?       103           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richfitz richfitz requested a review from r-ash July 6, 2023 10:01
Copy link
Contributor

@r-ash r-ash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really quite nice in the end!

@r-ash r-ash merged commit 864b453 into main Jul 6, 2023
@r-ash
Copy link
Contributor

r-ash commented Jul 6, 2023

Agh sorry I merged this before branch unpinning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants