feat: add logs_dir as inout to queue

.gitignore

@@ -15,4 +15,3 @@ docs
 .valgrind_ignore
 inst/doc
 pkgdown
-logs

R/queue.R

@@ -17,7 +17,8 @@ Queue <- R6::R6Class("Queue", # nolint
     #' @param root Orderly root.
     #' @param queue_id ID of an existing queue to connect to, creates a new one
     #'   if NULL (default NULL)
-    initialize = function(root, queue_id = NULL) {
+    #'   @param logs_dir directory to store worker logs 
+    initialize = function(root, queue_id = NULL, logs_dir = "logs/worker") {
       self$root <- root
       self$config <- orderly2::orderly_config(self$root)
       if (!runner_has_git(self$root)) {
@@ -35,9 +36,8 @@ Queue <- R6::R6Class("Queue", # nolint
         queue_id %||% orderly_queue_id(),
         con = con
       )
-      log_dir_name <- "logs/worker"
-      dir.create(log_dir_name, showWarnings = FALSE)
-      worker_config <- rrq::rrq_worker_config(heartbeat_period = 10, logdir = log_dir_name)
+      dir.create(logs_dir, showWarnings = FALSE)
+      worker_config <- rrq::rrq_worker_config(heartbeat_period = 10, logdir = logs_dir)
       rrq::rrq_worker_config_save("localhost", worker_config,
         controller = self$controller
       )

tests/testthat/helper-orderly-runner.R

@@ -122,7 +122,7 @@ start_queue_workers_quietly <- function(n_workers,
 start_queue_with_workers <- function(
   root, n_workers, env = parent.frame(), queue_id = NULL
 ) {
-  q <- new_queue_quietly(root, queue_id = queue_id)
+  q <- new_queue_quietly(root, queue_id = queue_id, logs_dir = tempfile())
   worker_manager <- start_queue_workers_quietly(n_workers, q$controller,
                                                 env = env)
   make_worker_dirs(root, worker_manager$id)

tests/testthat/test-api.R

@@ -96,7 +96,7 @@ test_that("can run orderly reports", {
   gert::git_init(repo)
   orderly2::orderly_gitignore_update("(root)", root = repo)
   git_add_and_commit(repo)
-  queue <- Queue$new(repo, queue_id = queue_id)
+  queue <- Queue$new(repo, queue_id = queue_id, logs_dir = tempfile())
   worker_manager <- start_queue_workers_quietly(
     1, queue$controller
   )

tests/testthat/test-queue.R

@@ -18,9 +18,10 @@ test_that("creates directory for logs & adds to worker config", {
 
   root <- create_temporary_root(use_file_store = TRUE)
   gert::git_init(root)
-  q <- new_queue_quietly(root)
-  expect_true(dir.exists("logs/worker"))
-  expect_equal("logs/worker", rrq::rrq_worker_config_read("localhost", controller = q$controller)$logdir)
+  logs_dir <- tempfile()
+  q <- new_queue_quietly(root, logs_dir = logs_dir)
+  expect_true(dir.exists(logs_dir))
+  expect_equal(logs_dir, rrq::rrq_worker_config_read("localhost", controller = q$controller)$logdir)
 })
 
 test_that("Errors if not git repo", {