Use entire api object in API tests. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plietar
force-pushed
the
refactor-api-test
branch
2 times, most recently
from
784dab2 to
6ca7e58
Compare
plietar
force-pushed
the
refactor-api-test
branch
from
6ca7e58 to
86b5002
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
- Coverage 99.44% 99.35% -0.10%
==========================================
Files 8 8
Lines 179 308 +129
==========================================
+ Hits 178 306 +128
- Misses 1 2 +1 ☔ View full report in Codecov by Sentry. |
The API tests used to setup individual endpoints to run the tests. That is a bit verbose and duplicates a bunch of code from the `api.R` file. This will be made much worse when we introduce `url` parameters to all the endpoints, since all the tests will need to make a API call to fetch the repository first, which will lead to more boilerplate. Using the api object solves this issue.
plietar
force-pushed
the
refactor-api-test
branch
from
86b5002 to
4c0ab5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API tests used to setup individual endpoints to run the tests. That is a bit verbose and duplicates a bunch of code from the
api.Rfile.This will be made much worse when we introduce
urlparameters to all the endpoints, since all the tests will need to make a API call to fetch the repository first, which will lead to more boilerplate.Using the api object solves this issue.