Set wd rather than using root= in vignettes #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 40
Lines 3512 3513 +1
=========================================
+ Hits 3512 3513 +1 ☔ View full report in Codecov by Sentry. |
plietar
approved these changes
Nov 20, 2023
vignettes/dependencies.Rmd
Outdated
| @@ -28,6 +28,16 @@ inline <- function(x) { | |||
|
|
|||
| knitr::opts_chunk$set( | |||
| collapse = TRUE) | |||
|
|
|||
| .here <- getwd() | |||
| knitr::knit_hooks$set(inwd = function(before, options) { | |||
There was a problem hiding this comment.
I think it would be worth moving a lot of this block into a common file that gets sourced by all the vignettes.
There was a problem hiding this comment.
yeah, good shout. I think we can do that with source() - I'll give that a go and see...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in mrc-4725, try and make things a bit more obvious. I've kept the explicit temporary directory used in the initial call to
orderly_initbut added a more explicit note, then used a knitr hook to change directory for the chunks that need it. It's generally not reliable to change for the whole document; knitr will try and change back, and generated files end up in the wrong place. We already used this approach to simplify the "collaboration" vignette